Fix double trailing slash in getClusterVersion #1001
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andre Kurait <[email protected]>
AndreKurait
requested review from
chelma,
gregschohn,
lewijacn,
mikaylathompson,
okhasawn,
peternied and
sumobrian
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1001 +/- ##
============================================
+ Coverage 80.17% 89.63% +9.46%
============================================
Files 370 43 -327
Lines 13622 2364 -11258
Branches 938 0 -938
============================================
- Hits 10921 2119 -8802
+ Misses 2130 245 -1885
+ Partials 571 0 -571
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Andre Kurait <[email protected]>
chelma
approved these changes
Sep 24, 2024
| @@ -67,7 +67,7 @@ protected OpenSearchClient(RestClient client, FailedRequestsLogger failedRequest | |||
| } | |||
|
|
|||
| public Version getClusterVersion() { | |||
| return client.getAsync("/", null) | |||
| return client.getAsync("", null) | |||
There was a problem hiding this comment.
Interesting. So we were doing something like curls -X GET https://<hostname>:9200//, and the double slash was accepted for self-host versions of OpenSearch, but not the managed version? That makes sense to me given all the processing they do.
There was a problem hiding this comment.
Yes, it was accepted on everything but 2.15 managed.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix double trailing slash in getClusterVersion since rest client was adding "/" which was causing 400 Bad Request in AWS against OS 2.15 (Note, was not causing issues in containers or other versions)
Bug Introduced in #922
Issues Resolved
Is this a backport? If so, please add backport PR # and/or commits #
Testing
Testing in AWS and unit tests added
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.